hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
thanks! the test.h in the patch description is missing a `#define X`. ================ Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:383 + !isHeaderFile(SM.getFileEntryForID(SM.getMainFileID())->getName(), + ASTCtx->getLangOpts()); ---------------- nit: move this var to Line 398, in some cases (builtin macros), it is not used, so would save some cost. this is duplicated with the one in `handleDeclOccurrence`, creating a new function seems not worthy... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84297/new/ https://reviews.llvm.org/D84297 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
