Author: uabelho
Date: Tue Aug 21 00:22:45 2018
New Revision: 340251
URL: http://llvm.org/viewvc/llvm-project?rev=340251&view=rev
Log:
Removed unused variable [NFC]
The compiler warned:
../tools/clang/lib/Sema/SemaType.cpp:6788:31: error: unused variable 'AT'
[-Werror,-Wunused-variable]
if (c
ioeric updated this revision to Diff 161651.
ioeric marked an inline comment as done.
ioeric added a comment.
- Improve tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50962
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/CodeComplete.cpp
clangd/CodeCo
ioeric added inline comments.
Comment at: unittests/clangd/CodeCompleteTests.cpp:1710
+ $bol^
+ ab$ab^
+ x.ab$dot^
kadircet wrote:
> Maybe an EXPECT for this one as well?
Nice catch!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/
mstorsjo created this revision.
mstorsjo added reviewers: craig.topper, erichkeane, rnk.
If using a custom stack alignment, one is expected to make sure that all
callers provide such alignment, or realign the stack in all entry points (and
callbacks).
Despite this, the compiler can assume that
ioeric added inline comments.
Comment at: lib/Basic/SourceManager.cpp:1705
// If we haven't found what we want yet, try again, but this time stat()
// each of the files in case the files have changed since we originally
Do we also need this in `findFileID
hokein added inline comments.
Comment at: clang-tidy/abseil/AbseilMatcher.h:16
+
+/// Matches AST nodes that were expanded within abseil-header-files.
+AST_POLYMORPHIC_MATCHER(isExpansionNotInAbseilHeader,
nit: We need proper documentation for this matcher, since
ilya-biryukov added inline comments.
Comment at: clangd/Cancellation.h:96
+/// checks using it to avoid extra lookups in the Context.
+class CancellationToken {
+public:
ioeric wrote:
> As chatted offline, I have questions about the motivation of the
> `Cancella
ioeric added inline comments.
Comment at: clangd/Cancellation.h:96
+/// checks using it to avoid extra lookups in the Context.
+class CancellationToken {
+public:
ilya-biryukov wrote:
> ioeric wrote:
> > As chatted offline, I have questions about the motivation o
lebedev.ri added inline comments.
Comment at: clang-tidy/abseil/AbseilMatcher.h:32
+ auto Filename = FileEntry->getName();
+ llvm::Regex RE("absl/(base|container|debugging|memory|meta|numeric|strings|"
+ "synchronization|types|utiliy)");
hokein
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
The patch looks good. I'll commit for you once @JonasToth has no further
comments.
https://reviews.llvm.org/D50862
___
cfe-commits mailing list
hokein added inline comments.
Comment at: clang-tidy/abseil/AbseilMatcher.h:32
+ auto Filename = FileEntry->getName();
+ llvm::Regex RE("absl/(base|container|debugging|memory|meta|numeric|strings|"
+ "synchronization|types|utiliy)");
lebedev.ri
hokein added a subscriber: deannagarcia.
hokein added a comment.
Your patch seems have some comments unaddressed but you marked done.
About the abseil matcher stuff, you and @deannagarcia have an overlap, maybe
just wait for https://reviews.llvm.org/D50580 to submit, and reuse the matcher
in th
lebedev.ri added inline comments.
Comment at: clang-tidy/abseil/AbseilMatcher.h:32
+ auto Filename = FileEntry->getName();
+ llvm::Regex RE("absl/(base|container|debugging|memory|meta|numeric|strings|"
+ "synchronization|types|utiliy)");
hokein
ilya-biryukov added a comment.
Herald added a subscriber: kadircet.
Just to make sure I fully understand the use-case: could you elaborate a little
more? Do you need to get exactly the same set of notes that clang provides?
Our current model seems to follow the clang's model, but it removes some
ilya-biryukov added a comment.
In https://reviews.llvm.org/D50703#1205167, @malaperle wrote:
> Nah, I guess other things are partial too, like Go to Definition. Let's
> assume they will be completed "soon" ;)
https://reviews.llvm.org/D50889 should finally add the symbols from the main
files.
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
https://reviews.llvm.org/D51029
Files:
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extr
kbobyrev planned changes to this revision.
kbobyrev added a comment.
Patch is in the preview mode, I will add documentation and more tests before
opening a review.
https://reviews.llvm.org/D51029
___
cfe-commits mailing list
cfe-commits@lists.llvm.
kbobyrev updated this revision to Diff 161677.
kbobyrev added a comment.
Add comprehensive tests, improve documentation.
https://reviews.llvm.org/D51029
Files:
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extra/clangd/index/dex/Iterator.cpp
clang-tools-extra/clangd/index/de
kbobyrev planned changes to this revision.
kbobyrev added a comment.
Since it's bundled with the BOOST iterator and doesn't make too much sense
without it, I should probable rebase on top of https://reviews.llvm.org/D50970
and add it as the parent revision.
https://reviews.llvm.org/D51029
_
rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D50984
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/MemIndex.h:50
+// FIXME(kbobyrev): Document this one.
+std::shared_ptr>
Please add documentation.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:96
+namespac
kbobyrev updated this revision to Diff 161679.
kbobyrev marked 2 inline comments as done.
kbobyrev added a comment.
Aww, the previous diff was the wrong one and didn't contain docs.
The move of the code to the middle of Clangd driver was justified by the
assumption that it might be better to mov
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D50897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ilya-biryukov added inline comments.
Comment at: clangd/Cancellation.h:96
+/// checks using it to avoid extra lookups in the Context.
+class CancellationToken {
+public:
ioeric wrote:
> ilya-biryukov wrote:
> > ioeric wrote:
> > > As chatted offline, I have quest
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340262: [clangd] Allow using experimental Dex index
(authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50897?vs=161679&id=1
Author: omtcyfz
Date: Tue Aug 21 03:32:27 2018
New Revision: 340262
URL: http://llvm.org/viewvc/llvm-project?rev=340262&view=rev
Log:
[clangd] Allow using experimental Dex index
This patch adds hidden Clangd flag ("use-dex-index") which replaces
(currently) default `MemIndex` with `DexIndex` for
Szelethus added inline comments.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp:223
+ // int*).
+ while (auto Tmp = V.getAs()) {
+// We can't reason about symbolic regions, assume its initialized.
Szelethus wrote:
> No
Author: omtcyfz
Date: Tue Aug 21 03:40:19 2018
New Revision: 340263
URL: http://llvm.org/viewvc/llvm-project?rev=340263&view=rev
Log:
[clangd] NFC: Fix broken build
Modified:
clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
Modified: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
URL:
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rC Clang
https://reviews.llvm.org/D50697
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
kadircet updated this revision to Diff 161683.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Put overrides through scoring and resolve nits.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50898
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
kadircet marked an inline comment as done.
kadircet added inline comments.
Comment at: clangd/CodeComplete.cpp:1233
+// struct/class/union definition.
+const auto Overrides = getVirtualNonOverridenMethods(
+Recorder->CCSema->CurContext, Recorder->CCSema);
ioeric added a comment.
In https://reviews.llvm.org/D50898#1205756, @hokein wrote:
> I think it is reasonable to make Sema support suggesting override methods,
> instead of implementing it in clangd side?
drive-by: +1 to this.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D5
Author: szelethus
Date: Tue Aug 21 03:45:21 2018
New Revision: 340265
URL: http://llvm.org/viewvc/llvm-project?rev=340265&view=rev
Log:
[analyzer][UninitializedObjectChecker] Refactoring p6.: Move dereferencing to a
function
Now that it has it's own file, it makes little sense for
isPointerOrRef
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340265: [analyzer][UninitializedObjectChecker] Refactoring
p6.: Move dereferencing to a… (authored by Szelethus, committed
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340266: [analyzer][UninitializedObjectChecker] Added
documentation to the checker list (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://r
Author: szelethus
Date: Tue Aug 21 03:47:19 2018
New Revision: 340266
URL: http://llvm.org/viewvc/llvm-project?rev=340266&view=rev
Log:
[analyzer][UninitializedObjectChecker] Added documentation to the checker list
Differential Revision: https://reviews.llvm.org/D50904
Modified:
cfe/trunk/l
ilya-biryukov added a comment.
1. Can we put the helper that executes the tasks asynchronously with a stack
size into llvm's threading library (i.e. somewhere close to
`llvm::execute_on_thread`?) All platform-specific code is already there, we can
reuse most of the implementation too.
2. I wond
smaksimovic updated this revision to Diff 161690.
smaksimovic added a comment.
Expanded a piece of code using switch cases as suggested.
https://reviews.llvm.org/D50557
Files:
include/clang/Basic/DiagnosticCommonKinds.td
lib/Basic/Targets/Mips.cpp
lib/Basic/Targets/Mips.h
test/Preproces
MTC added a comment.
@xazax.hun What do you think?
https://reviews.llvm.org/D48027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
QF5690 updated this revision to Diff 161684.
QF5690 added a comment.
Using `isObjCARCImplicitlyUnretainedType` instead of `isObjCClassType`
Tests in `property-in-class-extension-1.m` relaxed to
`-Wproperty-attribute-mismatch` (was `-Weverything`)
Repository:
rC Clang
https://reviews.llvm.org
ilya-biryukov updated this revision to Diff 161694.
ilya-biryukov marked 3 inline comments as done.
ilya-biryukov added a comment.
- Move DynamicIndex into ClangdServer.cpp
- Rename FileIdx to DynamicIdx
- Avoid modifying input args
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:70
+// FIXME(ibiryukov): this should be a generic helper instead.
+class NoopCallbacks : public ParsingCallbacks {
public:
ioeric wrote:
> Maybe provide noop implementations for `ParsingCal
Author: inouehrs
Date: Tue Aug 21 04:41:41 2018
New Revision: 340271
URL: http://llvm.org/viewvc/llvm-project?rev=340271&view=rev
Log:
Add missing library dependency to fix build break after rC340247
Modified:
cfe/trunk/lib/ARCMigrate/CMakeLists.txt
Modified: cfe/trunk/lib/ARCMigrate/CMakeLi
Szelethus added a comment.
In https://reviews.llvm.org/D50488#1204655, @mgrang wrote:
> In https://reviews.llvm.org/D50488#1203876, @Szelethus wrote:
>
> >
>
>
> This is my first time with ASTMatchers and I am not sure how to get the
> value_type from hasType (I don't see a matcher for value_typ
martong updated this revision to Diff 161698.
martong marked an inline comment as done.
martong added a comment.
- Change comments
Repository:
rC Clang
https://reviews.llvm.org/D50451
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTImporter.cpp
lib/ASTMatchers/ASTMatchersInte
martong marked an inline comment as done.
martong added inline comments.
Comment at: lib/AST/ASTImporter.cpp:4550
+ // in the "From" context, but not in the "To" context.
+ for (auto *FromField : D->fields())
+Importer.Import(FromField);
a_sidor
martong updated this revision to Diff 161699.
martong added a comment.
- Add one more TODO to import instantiated exception specifications
Repository:
rC Clang
https://reviews.llvm.org/D50451
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTImporter.cpp
lib/ASTMatchers/ASTMatc
Author: szelethus
Date: Tue Aug 21 05:16:59 2018
New Revision: 340272
URL: http://llvm.org/viewvc/llvm-project?rev=340272&view=rev
Log:
[analyzer][UninitializedObjectChecker] Explicit namespace resolution for
inherited data members
For the following example:
struct Base {
int x;
};
/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340272: [analyzer][UninitializedObjectChecker] Explicit
namespace resolution for… (authored by Szelethus, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50905?vs=161271&id=161700#toc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340272: [analyzer][UninitializedObjectChecker] Explicit
namespace resolution for… (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: rnkovacs.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D51001
___
cfe-commits mailing list
cfe-commits@lis
erichkeane added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:989
+CGM.getCodeGenOpts().StackAlignment)
+ Fn->addFnAttr("stackrealign");
+
Is there not an attribute name for this already in LLVM? I guess I'm otherwise
fine with this
mstorsjo added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:989
+CGM.getCodeGenOpts().StackAlignment)
+ Fn->addFnAttr("stackrealign");
+
erichkeane wrote:
> Is there not an attribute name for this already in LLVM? I guess I'm
> othe
Dmitry.Kozhevnikov added a comment.
In https://reviews.llvm.org/D50993#1207357, @ilya-biryukov wrote:
> 1. Can we put the helper that executes the tasks asynchronously with a stack
> size into llvm's threading library (i.e. somewhere close to
> `llvm::execute_on_thread`?) All platform-specific
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D50557
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
kristina added a comment.
In https://reviews.llvm.org/D50564#1206393, @mstorsjo wrote:
> In https://reviews.llvm.org/D50564#1206370, @cdavis5x wrote:
>
> > In https://reviews.llvm.org/D50564#1206302, @kristina wrote:
> >
> > > I'm all for this change except the core issue is that you're using
>
ilya-biryukov added a comment.
In https://reviews.llvm.org/D50993#1207464, @Dmitry.Kozhevnikov wrote:
> Do you think it would be OK to have pthreads-only version there, with
> `std::thread` fallback on Windows? I'd like to avoid writing a Windows-only
> implementation myself, as it's a bit alie
homerdin accepted this revision.
homerdin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for fixing this
Repository:
rT test-suite
https://reviews.llvm.org/D51020
___
cfe-commits mailing list
cfe-commits@lists.llvm
melver created this revision.
Herald added a subscriber: cfe-commits.
This fixes formatting namespaces with preceding 'inline' and 'export' (Modules
TS) specifiers.
This change fixes namespaces not being identified as such with preceding
'inline' or 'export' specifiers.
Motivation: I was exper
ldionne added inline comments.
Comment at: include/stddef.h:55
// Re-use the compiler's max_align_t where possible.
#if !defined(__CLANG_MAX_ALIGN_T_DEFINED) && !defined(_GCC_MAX_ALIGN_T) && \
chandlerc wrote:
> Unrelated to your patch, but this comment is n
hugoeg updated this revision to Diff 161714.
hugoeg marked an inline comment as done.
hugoeg added a comment.
All comments have been address and documentation has been added to matcher
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists
Author: balazske
Date: Tue Aug 21 07:32:21 2018
New Revision: 340277
URL: http://llvm.org/viewvc/llvm-project?rev=340277&view=rev
Log:
[ASTImporter] Adding some friend function related unittests.
Reviewers: a.sidorin, a_sidorin
Reviewed By: a_sidorin
Subscribers: a_sidorin, martong, cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340277: [ASTImporter] Adding some friend function related
unittests. (authored by balazske, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49798?vs=160972&id=161715#toc
Repository:
ilya-biryukov updated this revision to Diff 161717.
ilya-biryukov added a comment.
- Provide noop callbacks implementation by default.
- Update docs.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50847
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/TUSchedul
kadircet updated this revision to Diff 161716.
kadircet marked 4 inline comments as done.
kadircet added a comment.
- Get rid of CancellationToken && Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
Files:
clangd/CMakeLists.txt
clangd/Cancellation.c
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:73
+
+ void onPreambleAST(PathRef Path, ASTContext &Ctx,
+ std::shared_ptr PP) override {
hokein wrote:
> I think `Ctx` should be a `pointer` which gives us a way (passi
ilya-biryukov updated this revision to Diff 161718.
ilya-biryukov added a comment.
- Use noop callbacks from the parent revision
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50889
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/index/FileIndex.cpp
clangd/i
If there are no objections I would like to revert this old commit that coverts
error about implicit function declaration into a warning.
We have decided to generate an error for this https://reviews.llvm.org/D31745
because for OpenCL variadic prototypes are disallowed (section 6.9.e,
https://w
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
All the issues should be addressed at this point
Comment at: clangd/ClangdServer.cpp:70
+// FIXME(ibiryukov): this should be a generic helper instead.
+class NoopCallbacks : public ParsingCallbacks {
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clangd/index/FileIndex.h:70
+ void
+ update(PathRef Path, ASTContext *AST, std::shared_ptr PP,
+ llvm::Optional> TopLevelDecls = llvm::None);
hokein wrote:
hugoeg added a comment.
Ok , so I've clean some stuff up, I'm currently working with @deannagarcia to
get https://reviews.llvm.org/D50580 submitted with the match I implemented for
us first, then will adjust this as necessary
https://reviews.llvm.org/D50542
_
deannagarcia updated this revision to Diff 161720.
deannagarcia marked 12 inline comments as done.
https://reviews.llvm.org/D50580
Files:
clang-tidy/abseil/AbseilMatcher.h
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/NoNamespaceCheck.cpp
clan
deannagarcia added inline comments.
Comment at: clang-tidy/abseil/AbseilMatcher.h:32
+ auto Filename = FileEntry->getName();
+ llvm::Regex RE("absl/(base|container|debugging|memory|meta|numeric|strings|"
+ "synchronization|types|utiliy)");
lebed
ilya-biryukov added a comment.
Looking at this one. (to make sure we don't clash with @ioeric)
Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:111
+ const static unsigned DEFAULT_BOOST_SCORE;
+
Maybe make it `constexpr` and put the value into the h
kadircet created this revision.
kadircet added reviewers: ilya-biryukov, ioeric, hokein.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Currently CodeCompleteCall only gets called after a comma or parantheses. This
patch makes sure it is called even at the cases like:
foo(1^
kadircet created this revision.
kadircet added reviewers: ilya-biryukov, ioeric, hokein.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51039
Files:
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clan
hugoeg added inline comments.
Comment at: clang-tidy/abseil/AbseilMatcher.h:32
+ auto Filename = FileEntry->getName();
+ llvm::Regex RE("absl/(base|container|debugging|memory|meta|numeric|strings|"
+ "synchronization|types|utiliy)");
deannagarci
Author: szelethus
Date: Tue Aug 21 08:09:22 2018
New Revision: 340280
URL: http://llvm.org/viewvc/llvm-project?rev=340280&view=rev
Log:
[analyzer] Correctly marked a virtual function 'override'
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp
kadircet added a comment.
After today's offline discussion I suppose we are not going to implement it
within Sema. And also I think getVirtualNonOverridenMethods is a pretty generic
function that has no ties to clangd, so it can be easily moved into Sema.
Should we still move it into a separate
Hi Anastasia,
Richard and I discussed the way to enforce the error w/o customizing
the diagnostic for OpenCL off-list and Richard proposed to use
"-Werror=implicit-function-declaration" command line option if error
is required. Will it work for you?
Thanks,
Alexey
On Tue, Aug 21, 2018 at 5:41 PM
xazax.hun accepted this revision.
xazax.hun added a comment.
Sorry for the delay, I think this is OK to commit.
As a possible improvement, I can imagine making it slightly stricter, e.g. you
could only skip QualifiedNames for inline namespaces and the beginning. Maybe
add support for staring wit
xazax.hun added a comment.
Oh, and thanks for working on this, this improvement was long overdue, but
everybody was busy with something else :)
https://reviews.llvm.org/D48027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added a subscriber: xazax.hun.
It introduces some false positives which are non-trivial to fix.
Ignore running the check in C++17.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51041
Files:
clang-ti
xazax.hun added inline comments.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:35
+ // it is not ture in C++17's template argument deduction.
+ if (!getLangOpts().CPlusPlus || getLangOpts().CPlusPlus17 ||
+ getLangOpts().CPlusPlus2a)
Isn't the chec
hokein added a comment.
Thanks for the updates. Looks mostly good, a few nits.
Comment at: clang-tidy/abseil/AbseilMatcher.h:32
+
+AST_POLYMORPHIC_MATCHER(isExpansionInAbseilHeader,
+AST_POLYMORPHIC_SUPPORTED_TYPES(
nit: this matcher nam
Hi Alexey,
I understand that avoiding adding extra diagnostics is desirable, but I am not
sure it's a good idea to accept and generate code that is not going to work.
Variadic functions are currently not expected to be supported by all OpenCL
targets hence we disallow this in the spec explicit
ldionne created this revision.
ldionne added a reviewer: ahatanak.
Herald added subscribers: cfe-commits, dexonsmith.
r306722 introduced a new note called
note_silence_unligned_allocation_unavailable
where I believe what was meant is note_silence_aligned_allocation_unavailable.
Repository:
rC
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
Thanks. Yes, it's a typo.
Repository:
rCXX libc++
https://reviews.llvm.org/D51043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ldionne
Date: Tue Aug 21 08:54:24 2018
New Revision: 340288
URL: http://llvm.org/viewvc/llvm-project?rev=340288&view=rev
Log:
[clang][NFC] Fix typo in the name of a note
Summary:
r306722 introduced a new note called
note_silence_unligned_allocation_unavailable
where I believe what was me
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340288: [clang][NFC] Fix typo in the name of a note
(authored by ldionne, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51043?vs=161737&id=1
Merged to 7.0 in r340289.
On Fri, Aug 17, 2018 at 10:19 AM, Nico Weber via cfe-commits
wrote:
> Author: nico
> Date: Fri Aug 17 10:19:06 2018
> New Revision: 340048
>
> URL: http://llvm.org/viewvc/llvm-project?rev=340048&view=rev
> Log:
> Make __shiftleft128 / __shiftright128 real compiler built-
rnkovacs accepted this revision.
rnkovacs added a comment.
In https://reviews.llvm.org/D48027#1203944, @MTC wrote:
> However this approach has limit. Given the code below, we cannot distinguish
> whether the `basic_string` is user-defined struct or namespace. That's means
> when the user provid
Author: arsenm
Date: Tue Aug 21 09:13:29 2018
New Revision: 340292
URL: http://llvm.org/viewvc/llvm-project?rev=340292&view=rev
Log:
AMDGPU: Move target code into TargetParser
Modified:
cfe/trunk/lib/Basic/Targets/AMDGPU.cpp
cfe/trunk/lib/Basic/Targets/AMDGPU.h
Modified: cfe/trunk/lib/Ba
arsenm closed this revision.
arsenm added a comment.
r340292
https://reviews.llvm.org/D50984
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: teemperor
Date: Tue Aug 21 09:36:49 2018
New Revision: 340297
URL: http://llvm.org/viewvc/llvm-project?rev=340297&view=rev
Log:
[ASTImporter] Add test for CXXForRangeStmt
Reviewers: a.sidorin, martong
Reviewed By: martong
Subscribers: rnkovacs, martong, cfe-commits
Differential Revisio
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340297: [ASTImporter] Add test for CXXForRangeStmt (authored
by teemperor, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51001
Files:
test/Import/cxx-for-range/Inputs/F.cpp
test/I
jfb added a comment.
Isn't this duplicating code in lib/Support/Unix/Threading.inc with a different
implementation?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
Author: epilk
Date: Tue Aug 21 09:47:04 2018
New Revision: 340301
URL: http://llvm.org/viewvc/llvm-project?rev=340301&view=rev
Log:
[Parser] Support alternative operator token keyword args in Objective-C++
rdar://30741878
Differential revision: https://reviews.llvm.org/D50527
Added:
cfe/tru
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340301: [Parser] Support alternative operator token keyword
args in Objective-C++ (authored by epilk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50527?vs=159995&id=161748#toc
Re
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:92
+ /// function, the parameter is needed to propagate through the tree.
+ virtual unsigned boost(DocID ID) const = 0;
Maybe add a note to the comment on why an `I
1 - 100 of 192 matches
Mail list logo
