hokein added inline comments.
================
Comment at: clang-tidy/abseil/AbseilMatcher.h:32
+ auto Filename = FileEntry->getName();
+ llvm::Regex RE("absl/(base|container|debugging|memory|meta|numeric|strings|"
+ "synchronization|types|utiliy)");
----------------
lebedev.ri wrote:
> hokein wrote:
> > The regex seems incomplete, we are missing `algorithm`, `time`
> > subdirectory.
> So what happens if open the namespace in a file that is located in my
> personal `absl/base` directory?
> It will be false-negatively not reported?
Yes, I'd say this is a known limitation.
https://reviews.llvm.org/D50580
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
