ilya-biryukov added inline comments.
================
Comment at: clangd/ClangdServer.cpp:70
+// FIXME(ibiryukov): this should be a generic helper instead.
+class NoopCallbacks : public ParsingCallbacks {
public:
----------------
ioeric wrote:
> Maybe provide noop implementations for `ParsingCallbacks::onPreambleAST()`
> and `ParsingCallbacks::onMainAST` by default?
I'll address this in a parent revision.
================
Comment at: clangd/ClangdServer.h:246
+ /// If present, an up-to-date of symbols in open files. Read via Index.
+ std::unique_ptr<DynamicIndex> FileIdx;
// If present, a merged view of FileIdx and an external index. Read via
Index.
----------------
ioeric wrote:
> nit: `s/FileIdx/DymIdx`? (also need to update the comment above)
Went with `DynamicIdx`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50889
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
