ioeric added inline comments.
================ Comment at: clang-tools-extra/clangd/index/MemIndex.h:50 +// FIXME(kbobyrev): Document this one. +std::shared_ptr<std::vector<const Symbol *>> ---------------- Please add documentation. ================ Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:96 +namespace { + ---------------- Why the move? A chunk of code in the middle of flags seems strange. https://reviews.llvm.org/D50897 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits