ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
All the issues should be addressed at this point
================
Comment at: clangd/ClangdServer.cpp:70
+// FIXME(ibiryukov): this should be a generic helper instead.
+class NoopCallbacks : public ParsingCallbacks {
public:
----------------
ilya-biryukov wrote:
> ioeric wrote:
> > Maybe provide noop implementations for `ParsingCallbacks::onPreambleAST()`
> > and `ParsingCallbacks::onMainAST` by default?
> I'll address this in a parent revision.
Done
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50889
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
