Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

[Anton Khorev via rails-dev]

@AntonKhorev commented on this pull request.



> +      svg = tag.a :href => "", :class => "wdt-preview", :data => { :qids => 
> wdt.map { |w| w[:title] } } do
+        tag.svg :width => 27, :height => 14, :class => "float-end m-1" do

Can you float the entire link? Otherwise its focus outline looks like this:
![image](https://github.com/user-attachments/assets/d913b60f-f8a6-4fce-963c-dc123584f9a1)

```suggestion
      svg = tag.a :href => "", :class => "wdt-preview float-end m-1 d-flex", 
:data => { :qids => wdt.map { |w| w[:title] } } do
        tag.svg :width => 27, :height => 14 do
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#pullrequestreview-2977271461
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6127/review/2977271...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev