@AntonKhorev commented on this pull request.


> @@ -136,6 +136,9 @@ overpass_credentials: false
 graphhopper_url: "https://graphhopper.com/api/1/route";
 fossgis_osrm_url: "https://routing.openstreetmap.de/";
 fossgis_valhalla_url: "https://valhalla1.openstreetmap.de/route";
+# Endpoints for Wikimedia integration
+wikidata_url: "https://www.wikidata.org/w/api.php";

A better name is `wikidata_api_url` because what if you want to generate a link 
to the wikidata web page, it won't have `w/api.php` in it. Or maybe add 
`w/api.php` in `explainWikidataLink` when building an url.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#pullrequestreview-2971160867
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6127/review/2971160...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to