@AntonKhorev commented on this pull request.


> @@ -17,10 +17,16 @@ def format_value(key, value)
     elsif wdt = wikidata_links(key, value)
       # IMPORTANT: Note that wikidata_links() returns an array of hashes, 
unlike for example wikipedia_link(),
       # which just returns one such hash.
+      svg = tag.a :href => "", :class => "float-end m-1 d-flex wdt-preview", 
:data => { :qids => wdt.map { |w| w[:title] } } do

I Bootstrap if `<a>` is replaced with `<button type="button">`, these extra 
classes will make it look like a link:
`btn btn-link border-0 p-0`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#pullrequestreview-2979706010
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6127/review/2979706...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to