@hlfan commented on this pull request.


> +      $("#sidebar-content").on("turbo:before-stream-render", event => {
+        const defaultRender = event.detail.render;
+        event.detail.render = function (streamElement) {
+          defaultRender(streamElement);
+          markWikidataLinksAsExplainable();
+        };
+      });

I was going to ask about implementing the behaviour this way, but with your 
comment about `not rewriting the tag value` I decided to not bring it up.

If I select `$("q-link-icon")` to attach the listeners, that selection wont be 
touched by turbo, right?
So watch `#element_versions_list` instead?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#discussion_r2175139534
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6127/review/2971335...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to