@AntonKhorev commented on this pull request.
> @@ -17,10 +17,16 @@ def format_value(key, value)
elsif wdt = wikidata_links(key, value)
# IMPORTANT: Note that wikidata_links() returns an array of hashes,
unlike for example wikipedia_link(),
# which just returns one such hash.
+ svg = tag.a :href => "", :class => "float-end m-1 d-flex wdt-preview",
:data => { :qids => wdt.map { |w| w[:title] } } do
For example, a screen reader is going to announce `<a>` as "Wikidata item
preview visited link", which it isn't and if you visit it as a link, you're not
getting wikidata item preview. `<button>` is announced as "Wikidata item
preview push button".
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#discussion_r2180492032
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6127/review/2979846...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
