@AntonKhorev commented on this pull request.
> + $("<img>")
+ .attr({ src: OSM.WIKIMEDIA_COMMONS_URL + "Special:FilePath/" +
data.icon, height: "32" })
+ .addClass("float-end mb-1 ms-2")
+ .appendTo(cell);
In case anyone asks for an image attribution, we can have it linked to its
Commons page.
```suggestion
$("<a>")
.attr({ href: OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon })
.append(
$("<img>")
.attr({ src: OSM.WIKIMEDIA_COMMONS_URL + "Special:FilePath/" +
data.icon, height: "32" }))
.addClass("float-end mb-1 ms-2")
.appendTo(cell);
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#pullrequestreview-2969284694
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6127/review/2969284...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
