@AntonKhorev commented on this pull request.
> + fetch(OSM.WIKIDATA_URL + "?" + new URLSearchParams({
+ action: "wbgetentities",
+ format: "json",
+ origin: "*",
+ ids: qid,
+ props: "labels|sitelinks|claims|descriptions",
+ languages: langs.join("|"),
+ sitefilter: wikis.join("|")
+ }))
I think we need:
1. Create an abort controller in `page.load`/`pushstate`/`popstate`.
2. Pass its signal to this fetch.
3. Abort in `page.unload`, this will stop all currently running fetches.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#pullrequestreview-2969271786
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6127/review/2969271...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
