hein added inline comments.

INLINE COMMENTS

> notificationgroupcollapsingproxymodel.cpp:52
> +            Q_UNUSED(bottomRight); // what about it?
> +            Q_UNUSED(roles);
> +

Not actually unused.

`bottomRight`: You sure the source model will emit for single cells? Otherwise 
you need to loop over the range.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20265

To: broulik, #plasma
Cc: hein, mart, nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Reply via email to