broulik marked an inline comment as done. broulik added inline comments. INLINE COMMENTS
> nicolasfella wrote in CMakeLists.txt:26 > It's in Extragear Changed code to use plasma-pa QML only now like in task manager > ngraham wrote in org.freedesktop.Notifications.xml:57 > Why is this commented out? Should it just be deleted instead? Or is it > supposed to be used? Was supposed to be a way for apps to query who's holding an inhibition but since it's inside plasmashell anyway I can just use that directly from the plasmoid without "polluting" the public API. Apps, if even needed, can query `Inhibited` property to see whether it's enabled or not > davidedmundson wrote in notificationgroupcollapsingproxymodel.cpp:133 > you shouldn't need this, the data is changing so it'll get re-evaluated `filterAcceptsRow` doesn't actually read `IsGroupExpanded` since `filterAcceptsRow` evaluates the source row, not our own REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20265 To: broulik, #plasma Cc: nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
