broulik marked 8 inline comments as done.
broulik added inline comments.

INLINE COMMENTS

> hein wrote in notifications.cpp:76
> Have you considered using `KModelIndexProxyMapper` from KF5::ItemModels?

I have, it doesn't work for this usecase. It can only map a tree via a single 
model, we have it the other way round, we have a single proxy chain diverging 
into two. Also, `KConcatenateRowsProxyModel` isn't a proper proxy model, so it 
completely breaks `KModelIndexProxyMapper`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20265

To: broulik, #plasma
Cc: hein, mart, nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Reply via email to