broulik added inline comments.

INLINE COMMENTS

> mart wrote in jobsmodel.cpp:72
> any reason to go this way instead of Q_GLOBAL_STATIC ?
> I guess you want to have cases in which none of it is ever created? tough the 
> case would be when there are no notification plasmoids, but in that case the 
> plugin containing the library wouldn't be loaded?

This library is not just for plasmoids, it is also used in the jobs dataengine 
for instance.
But yeah I want some refcounting so the model stuff is only done when there's 
actually someone using it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20265

To: broulik, #plasma
Cc: mart, nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Reply via email to