broulik updated this revision to Diff 56056. broulik edited the summary of this revision. broulik added a comment.
- Address review comments - Rewrite job handling to be kuiserver and kill it I removed the dataengine rewrite from the diff to make it a bit less overwhelming, will come up as separate patch kuiserver removal is also not in the diff as that's just deleting the folder and removing it from CMakeLists REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20265?vs=55470&id=56056 REVISION DETAIL https://phabricator.kde.org/D20265 AFFECTED FILES libnotificationmanager/CMakeLists.txt libnotificationmanager/LibNotificationManagerConfig.cmake.in libnotificationmanager/autotests/CMakeLists.txt libnotificationmanager/autotests/notifications_test.cpp libnotificationmanager/dbus/org.freedesktop.Notifications.xml libnotificationmanager/dbus/org.kde.JobViewServer.xml libnotificationmanager/dbus/org.kde.JobViewServerV2.xml libnotificationmanager/dbus/org.kde.JobViewV2.xml libnotificationmanager/dbus/org.kde.JobViewV3.xml libnotificationmanager/dbus/org.kde.kuiserver.xml libnotificationmanager/declarative/CMakeLists.txt libnotificationmanager/declarative/notificationmanagerplugin.cpp libnotificationmanager/declarative/notificationmanagerplugin.h libnotificationmanager/declarative/qmldir libnotificationmanager/job.cpp libnotificationmanager/job.h libnotificationmanager/job_p.cpp libnotificationmanager/job_p.h libnotificationmanager/jobsmodel.cpp libnotificationmanager/jobsmodel.h libnotificationmanager/jobsmodel_p.cpp libnotificationmanager/jobsmodel_p.h libnotificationmanager/kcfg/badgesettings.kcfg libnotificationmanager/kcfg/badgesettings.kcfgc libnotificationmanager/kcfg/donotdisturbsettings.kcfg libnotificationmanager/kcfg/donotdisturbsettings.kcfgc libnotificationmanager/kcfg/jobsettings.kcfg libnotificationmanager/kcfg/jobsettings.kcfgc libnotificationmanager/kcfg/notificationsettings.kcfg libnotificationmanager/kcfg/notificationsettings.kcfgc libnotificationmanager/libnotificationmanager.categories libnotificationmanager/limitedrowcountproxymodel.cpp libnotificationmanager/limitedrowcountproxymodel_p.h libnotificationmanager/notification.cpp libnotificationmanager/notification.h libnotificationmanager/notification_p.h libnotificationmanager/notificationfilterproxymodel.cpp libnotificationmanager/notificationfilterproxymodel_p.h libnotificationmanager/notificationgroupcollapsingproxymodel.cpp libnotificationmanager/notificationgroupcollapsingproxymodel_p.h libnotificationmanager/notificationgroupingproxymodel.cpp libnotificationmanager/notificationgroupingproxymodel_p.h libnotificationmanager/notifications.cpp libnotificationmanager/notifications.h libnotificationmanager/notificationsmodel.cpp libnotificationmanager/notificationsmodel.h libnotificationmanager/notificationsortproxymodel.cpp libnotificationmanager/notificationsortproxymodel_p.h libnotificationmanager/plasmanotifyrc libnotificationmanager/server.cpp libnotificationmanager/server.h libnotificationmanager/server_p.cpp libnotificationmanager/server_p.h libnotificationmanager/settings.cpp libnotificationmanager/settings.h libnotificationmanager/utils.cpp libnotificationmanager/utils_p.h To: broulik, #plasma Cc: nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
