----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103007/#review7952 -----------------------------------------------------------
the config UI looks good.. only changes i might make are to set the rules to have header()->setResizeMode(QHeaderView::ResizeToContents) and to shorten the name from "Launcher Matching Rules" to just "Launchers" (it looks rather long in the page listing on the left) - Aaron J. Seigo On Nov. 3, 2011, 9:21 p.m., Craig Drummond wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103007/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2011, 9:21 p.m.) > > > Review request for Plasma. > > > Description > ------- > > 1. If fail to automatically find launcher, then prompt user to select from > installed applications. > 2. Add a config page, so that manualy set launchers may be adjusted. > > (Part of IconTasks' taskmanager changes) > > > Diffs > ----- > > libs/taskmanager/CMakeLists.txt 6ae36dc > libs/taskmanager/groupmanager.h acaa142 > libs/taskmanager/groupmanager.cpp 6e7ffa7 > libs/taskmanager/launcherconfig.h PRE-CREATION > libs/taskmanager/launcherconfig.cpp PRE-CREATION > libs/taskmanager/launcherconfig.ui PRE-CREATION > libs/taskmanager/launcherproperties.h PRE-CREATION > libs/taskmanager/launcherproperties.cpp PRE-CREATION > libs/taskmanager/launcherproperties.ui PRE-CREATION > libs/taskmanager/taskactions.cpp 011c565 > libs/taskmanager/taskactions_p.h 407b2c9 > libs/taskmanager/taskitem.h 3c84678 > libs/taskmanager/taskitem.cpp e2c07d8 > > Diff: http://git.reviewboard.kde.org/r/103007/diff/diff > > > Testing > ------- > > > Thanks, > > Craig Drummond > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
