On Tue, 7 Apr 2026 17:19:23 GMT, Andy Goryachev <[email protected]> wrote:

>> In the exceptionally degenerate edge case when `prevState == null && 
>> newState != null`, we might need to fire a notification that everything in 
>> the selection set is added. With a custom sort policy, anything is possible!
>
> should we create a unit test for this exact scenario?

You mean changing the `selectionModel` in the sorting policy? I do think this 
is an edge case, but we could have a basic check for that probably. Before we 
try to assign `newState`, we can check if the `selectionModel` is null and 
return fast?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2131#discussion_r3047211230

Reply via email to