On Tue, 7 Apr 2026 15:17:34 GMT, Andy Goryachev <[email protected]> wrote:
>> Charlie Schlosser has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> update copyright headers
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TableView.java
> line 1734:
>
>> 1732: setComparator(oldComparator);
>> 1733: sortLock = false;
>> 1734: } else if (prevState != null) {
>
> I wonder if it would make sense to add tests that exercise transition of the
> selection model from non-null to null and back, while tree/table is sorted.
>
> What do you guys think?
Do your changes here address that concern?
https://github.com/openjdk/jfx/pull/876/changes#diff-7b076b4153cd990da07d19831701b794278e0c875584e32505bb89c6dd2208d4
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2131#discussion_r3046574154
