On Tue, 7 Apr 2026 17:11:32 GMT, Charlie Schlosser <[email protected]> wrote:
>> hmm, partially: >> - all three `TreeItem`s have the same "" value, so sorting is probably a >> no-op >> - I don't know whether (prevState == null) case is being tested: I see the >> sorting is done with a null model, but there is no sorting done after >> setting a non-null selection model. >> >> Having said that, I think the fact that you already have a sorting test case >> with a null selection model is probably good enough. > > In the exceptionally degenerate edge case when `prevState == null && newState > != null`, we might need to fire a notification that everything in the > selection set is added. With a custom sort policy, anything is possible! should we create a unit test for this exact scenario? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2131#discussion_r3046728966
