On Mon, 6 Apr 2026 22:19:07 GMT, Andy Goryachev <[email protected]> wrote:

> Looks good! There is a definite performance improvement with this fix 
> (although a TreeTableView with 100,000 items still produces a beach ball for 
> some seconds on macOS).
> 
> I agree with @Maran23 's suggestions, will re-approve once you make the 
> changes.

`TreeTableView` has other problems, namely that every `getItem` call starts a 
DFS from root. While the sort is fixed for `TreeTableView`, calling `selectAll` 
would take days for 100k+ items.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2131#issuecomment-4196338875

Reply via email to