On Tue, 7 Apr 2026 17:00:14 GMT, Andy Goryachev <[email protected]> wrote:
>> Do your changes here address that concern? >> >> https://github.com/openjdk/jfx/pull/876/changes#diff-7b076b4153cd990da07d19831701b794278e0c875584e32505bb89c6dd2208d4 > > hmm, partially: > - all three `TreeItem`s have the same "" value, so sorting is probably a no-op > - I don't know whether (prevState == null) case is being tested: I see the > sorting is done with a null model, but there is no sorting done after setting > a non-null selection model. > > Having said that, I think the fact that you already have a sorting test case > with a null selection model is probably good enough. In the exceptionally degenerate edge case when `prevState == null && newState != null`, we might need to fire a notification that everything in the selection set is added. With a custom sort policy, anything is possible! ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2131#discussion_r3046691168
