Copilot commented on code in PR #3634:
URL: https://github.com/apache/thrift/pull/3634#discussion_r3566677802
##########
test/tests.json:
##########
@@ -468,6 +468,131 @@
],
"workdir": "rb/gen-rb"
},
+ {
+ "name": "rb",
+ "client": {
+ "timeout": 10,
+ "command": [
+ "ruby",
+ "../integration/TestClient.rb",
+ "--"
+ ]
+ },
+ "transports": [
+ "http"
+ ],
+ "sockets": [
+ "ip",
+ "ip-ssl"
+ ],
+ "protocols": [
+ "binary",
+ "binary:accel",
+ "compact",
+ "json",
+ "header",
+ "multi",
+ "multic",
+ "multih",
+ "multij"
+ ],
+ "workdir": "rb/gen-rb"
+ },
+ {
+ "name": "rb.thin",
+ "stop_signal": 2,
+ "server": {
+ "command": [
+ "bundle",
+ "exec",
+ "ruby",
+ "../integration/TestServer.rb"
+ ],
+ "extra_args": ["thin"]
+ },
+ "transports": [
+ "http"
+ ],
+ "sockets": [
+ "ip",
+ "ip-ssl"
+ ],
+ "protocols": [
+ "binary",
+ "binary:accel",
+ "compact",
+ "json",
+ "header",
+ "multi",
+ "multic",
+ "multih",
+ "multij"
+ ],
+ "workdir": "rb/gen-rb"
+ },
+ {
+ "name": "rb.puma",
+ "stop_signal": 2,
+ "server": {
+ "command": [
+ "bundle",
+ "exec",
+ "ruby",
+ "../integration/TestServer.rb"
+ ],
+ "extra_args": ["puma"]
+ },
+ "transports": [
+ "http"
+ ],
+ "sockets": [
+ "ip",
+ "ip-ssl"
+ ],
+ "protocols": [
+ "binary",
+ "binary:accel",
+ "compact",
+ "json",
+ "header",
+ "multi",
+ "multic",
+ "multih",
+ "multij"
+ ],
+ "workdir": "rb/gen-rb"
+ },
+ {
+ "name": "rb.falcon",
+ "server": {
Review Comment:
`rb.falcon` does not set `stop_signal`, so crossrunner will use the default
(SIGHUP / signal 1). In `crossrunner/run.py`, a server that doesn't exit on the
configured signal is marked as `killed`, which turns into a test failure. To
avoid flaky shutdown behavior for Falcon (and to match `rb.thin`/`rb.puma`),
set an explicit stop signal such as SIGINT (2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
