Copilot commented on code in PR #3634:
URL: https://github.com/apache/thrift/pull/3634#discussion_r3566818948
##########
test/tests.json:
##########
@@ -468,6 +468,131 @@
],
"workdir": "rb/gen-rb"
},
+ {
+ "name": "rb",
+ "client": {
+ "timeout": 10,
+ "command": [
+ "ruby",
+ "../integration/TestClient.rb",
+ "--"
+ ]
+ },
+ "transports": [
+ "http"
+ ],
+ "sockets": [
+ "ip",
+ "ip-ssl"
+ ],
+ "protocols": [
+ "binary",
+ "binary:accel",
+ "compact",
+ "json",
+ "header",
+ "multi",
+ "multic",
+ "multih",
+ "multij"
+ ],
+ "workdir": "rb/gen-rb"
+ },
+ {
+ "name": "rb.thin",
+ "stop_signal": 2,
+ "server": {
+ "command": [
+ "bundle",
+ "exec",
+ "ruby",
+ "../integration/TestServer.rb"
+ ],
+ "extra_args": ["thin"]
+ },
+ "transports": [
+ "http"
+ ],
+ "sockets": [
+ "ip",
+ "ip-ssl"
+ ],
+ "protocols": [
+ "binary",
+ "binary:accel",
+ "compact",
+ "json",
+ "header",
+ "multi",
+ "multic",
+ "multih",
+ "multij"
+ ],
+ "workdir": "rb/gen-rb"
+ },
+ {
+ "name": "rb.puma",
+ "stop_signal": 2,
+ "server": {
+ "command": [
+ "bundle",
+ "exec",
+ "ruby",
+ "../integration/TestServer.rb"
+ ],
+ "extra_args": ["puma"]
+ },
+ "transports": [
+ "http"
+ ],
+ "sockets": [
+ "ip",
+ "ip-ssl"
+ ],
+ "protocols": [
+ "binary",
+ "binary:accel",
+ "compact",
+ "json",
+ "header",
+ "multi",
+ "multic",
+ "multih",
+ "multij"
+ ],
+ "workdir": "rb/gen-rb"
+ },
+ {
+ "name": "rb.falcon",
+ "server": {
Review Comment:
`rb.falcon` does not set `stop_signal`, so it inherits the crossrunner
default (SIGHUP / 1). In crossrunner, servers are expected to exit cleanly when
signaled; if Falcon doesn’t terminate on SIGHUP, the runner escalates to
SIGKILL and flags the test as killed/error. Set `stop_signal` to SIGINT (2),
consistent with `rb.thin`/`rb.puma`, so Falcon shuts down gracefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
