Copilot commented on code in PR #3634:
URL: https://github.com/apache/thrift/pull/3634#discussion_r3566612385
##########
test/tests.json:
##########
@@ -468,6 +468,130 @@
],
"workdir": "rb/gen-rb"
},
+ {
+ "name": "rb",
+ "client": {
Review Comment:
`tests.json` now contains two separate library entries with the same
`"name": "rb"` (one with server+client for buffered/framed, and another
client-only entry for HTTP). Because the cross-test runner matches
configurations by this `name`, this makes it impossible to select only one of
these Ruby client configurations (and can make failures/known-failures hard to
interpret since both present as `rb`). Consider giving the HTTP-only client a
distinct name (e.g. `rb.http-client`) and updating the workflow matrix /
known-failures accordingly, or otherwise documenting/structuring the config so
the split is unambiguous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
