Copilot commented on code in PR #3634:
URL: https://github.com/apache/thrift/pull/3634#discussion_r3566708190
##########
test/rb/integration/TestServer.rb:
##########
@@ -250,7 +267,61 @@ def secondtestString(argument)
end
workers = options[:workers] || 20
+keys_dir = File.join(File.dirname(File.dirname(Dir.pwd)), 'keys')
+if rack_server
+ require 'thrift/server/rack_application'
+ rack_app = Thrift::RackApplication.mapped('/', processor, protocol_factory)
+end
Review Comment:
`rack_app` is only used in the `puma`/`falcon` branches below, but it is
currently constructed (and `thrift/server/rack_application` is required) for
`thin` as well. This is unnecessary work during startup and makes the control
flow a bit harder to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
