Copilot commented on code in PR #3634:
URL: https://github.com/apache/thrift/pull/3634#discussion_r3566656366
##########
test/tests.json:
##########
@@ -468,6 +468,130 @@
],
"workdir": "rb/gen-rb"
},
+ {
+ "name": "rb",
+ "client": {
+ "timeout": 10,
+ "command": [
+ "ruby",
+ "../integration/TestClient.rb",
+ "--"
+ ]
+ },
+ "transports": [
+ "http"
+ ],
+ "sockets": [
+ "ip",
+ "ip-ssl"
+ ],
+ "protocols": [
+ "binary",
+ "binary:accel",
+ "compact",
+ "json",
+ "header",
+ "multi",
+ "multic",
+ "multih",
+ "multij"
+ ],
+ "workdir": "rb/gen-rb"
+ },
+ {
+ "name": "rb.thin",
+ "stop_signal": 2,
+ "server": {
+ "command": [
+ "bundle",
+ "exec",
+ "ruby",
+ "../integration/TestServer.rb"
+ ],
+ "extra_args": ["thin"]
+ },
+ "transports": [
+ "http"
+ ],
+ "sockets": [
+ "ip",
+ "ip-ssl"
+ ],
+ "protocols": [
+ "binary",
+ "binary:accel",
+ "compact",
+ "json",
+ "header",
+ "multi",
+ "multic",
+ "multih",
+ "multij"
+ ],
+ "workdir": "rb/gen-rb"
+ },
+ {
+ "name": "rb.puma",
+ "server": {
+ "command": [
Review Comment:
`rb.puma` does not specify `stop_signal`, so crossrunner will stop it with
the default signal (1/SIGHUP). `crossrunner/run.py` treats servers with a
non-zero stop_signal as an error if they don’t exit promptly and need to be
SIGTERM’d (marked as “killed”). Puma commonly handles SIGHUP as a
reload/phased-restart signal rather than exiting, which can cause the server to
be force-killed and the test marked failed.
Set an explicit stop signal that Puma will treat as a clean shutdown (e.g.,
SIGINT) so the server exits within the graceful-stop window.
##########
test/tests.json:
##########
@@ -468,6 +468,130 @@
],
"workdir": "rb/gen-rb"
},
+ {
+ "name": "rb",
+ "client": {
+ "timeout": 10,
+ "command": [
+ "ruby",
+ "../integration/TestClient.rb",
+ "--"
+ ]
+ },
+ "transports": [
+ "http"
+ ],
+ "sockets": [
+ "ip",
+ "ip-ssl"
+ ],
+ "protocols": [
+ "binary",
+ "binary:accel",
+ "compact",
+ "json",
+ "header",
+ "multi",
+ "multic",
+ "multih",
+ "multij"
+ ],
+ "workdir": "rb/gen-rb"
+ },
+ {
+ "name": "rb.thin",
+ "stop_signal": 2,
+ "server": {
+ "command": [
+ "bundle",
+ "exec",
+ "ruby",
+ "../integration/TestServer.rb"
+ ],
+ "extra_args": ["thin"]
+ },
+ "transports": [
+ "http"
+ ],
+ "sockets": [
+ "ip",
+ "ip-ssl"
+ ],
+ "protocols": [
+ "binary",
+ "binary:accel",
+ "compact",
+ "json",
+ "header",
+ "multi",
+ "multic",
+ "multih",
+ "multij"
+ ],
+ "workdir": "rb/gen-rb"
+ },
+ {
+ "name": "rb.puma",
+ "server": {
+ "command": [
+ "bundle",
+ "exec",
+ "ruby",
+ "../integration/TestServer.rb"
+ ],
+ "extra_args": ["puma"]
+ },
+ "transports": [
+ "http"
+ ],
+ "sockets": [
+ "ip",
+ "ip-ssl"
+ ],
+ "protocols": [
+ "binary",
+ "binary:accel",
+ "compact",
+ "json",
+ "header",
+ "multi",
+ "multic",
+ "multih",
+ "multij"
+ ],
+ "workdir": "rb/gen-rb"
+ },
+ {
+ "name": "rb.falcon",
+ "server": {
+ "command": [
Review Comment:
`rb.falcon` does not specify `stop_signal`, so crossrunner will stop it with
the default signal (1/SIGHUP). If Falcon handles SIGHUP for reload semantics
instead of exiting, crossrunner will escalate to SIGTERM, mark the server as
killed, and treat that as a test error.
Set an explicit stop signal that Falcon will treat as a clean shutdown
(e.g., SIGINT) so the server exits gracefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
