CJCombrink commented on PR #2943: URL: https://github.com/apache/thrift/pull/2943#issuecomment-2023790975
I did some thinking... For a major project like this, a PR touching 56 files with more than 10,135 changes from a random person might not be the easiest thing to consider. Thus, would it not be better if we keep the changes local to one generator and then maybe in future consider this type of change? Obviously I would want the changes in `t_cpp_generator.cc` Or maybe just make the changes in the generators. I did go all the way with all other files, but baby steps might be the best or safest course of action. PS: I started a new ticket: [THRIFT-5772](https://issues.apache.org/jira/browse/THRIFT-5772) and if I have to choose I would rather have energy put there compared to this change, although this would be nice to have (in the C++ generator :P ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
