CJCombrink commented on PR #2943: URL: https://github.com/apache/thrift/pull/2943#issuecomment-2050233861
@Jens-G > Most of the missing single lines are `cerr` outputs. I mean, if we want to save walls, we should be more consequent and include `cerr `outputs as well, maybe doing the flush explicitly if needed. Or would `cerr `be the exception from the rule that `endl `is generally evil? Initially I thought it might be good to keep cerr to flush. After your comment I did some thinking and reading and I see `std::cerr` is unbuffered, thus every `<<` will flush and `endl` will then be a double flush, thus I think it is safe to conclude it is evil there as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
