emmenlau commented on PR #2943: URL: https://github.com/apache/thrift/pull/2943#issuecomment-1997294219
@CJCombrink from my point of view, everything else is good, thanks a lot for the nice work! The build failures are a continuous nightmare. The best you could do (and this is what I typically do) is check them individually, and see if the error seems related. Often builds fail because some third party dependency package can not be installed in some build machine, and those are the obvious ones to ignore. The others are harder, for those you can just compare the latest master build status with yours, to see if "you" broke it, or the person before you... In any case, we will also take a look at those before merging, but its great if you validate as much as you can upfront... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
