CJCombrink commented on code in PR #2943:
URL: https://github.com/apache/thrift/pull/2943#discussion_r1561389263
##########
compiler/cpp/src/thrift/generate/t_kotlin_generator.cc:
##########
@@ -1972,16 +1970,15 @@ bool t_kotlin_generator::is_enum_map(t_type* ttype) {
*/
string t_kotlin_generator::kotlin_package() {
if (!package_name_.empty()) {
- return string("package ") + package_name_ + endl + endl;
+ return string("package ") + package_name_ + string{"\n\n"};
}
Review Comment:
Habit... Updated to ` ... + "\n" + "\n"`
See [ES.23: Prefer the {}-initializer
syntax](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es23-prefer-the--initializer-syntax)
In the spirit of the PR and keeping with the format of the surrounding code
I updated as mentioned above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
