CJCombrink commented on code in PR #2943:
URL: https://github.com/apache/thrift/pull/2943#discussion_r1524246076
##########
compiler/cpp/src/thrift/generate/t_cl_generator.cc:
##########
@@ -221,11 +221,11 @@ void t_cl_generator::package_def(std::ostream &out) {
}
out << ")";
}
- out << ")" << endl << endl;
+ out << ")\n\n";
Review Comment:
@fishy Thanks for the review and feedback.
Although I do understand the suggestion I specifically went through the
effort to combine these. It does sort of stand out, but some editors color the
`\n` different and I deem that good enough. I find myself looking at the
generated code much more often compared to the generator code thus there I
quickly see how much (or few) newlines are added.
If there is enough pushback against the combination I can revert that
combination change and (force)push the updates.
I don't think speed matters that much but I guess calling the `operator<<`
multiple times, more than the needed amount of time, would have a performance
and speed implication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
