villebro commented on code in PR #32506:
URL: https://github.com/apache/superset/pull/32506#discussion_r1980518826
##########
superset/db_engine_specs/postgres.py:
##########
@@ -411,7 +411,9 @@ def get_table_names(
)
@staticmethod
- def get_extra_params(database: Database) -> dict[str, Any]:
+ def get_extra_params(
+ database: Database, source: QuerySource | None = None
+ ) -> dict[str, Any]:
Review Comment:
@korbit-ai I still don't agree. Adding too obvious comments to docstrings
will only add cognitive load to already burdened developers, and is not helpful
in this case. Stating that "the source parameter can be used by your database
spec if the underlying database supports it" does not help. It's like
commenting "use the event prop in the `onChange` handler if you need to know
details about the event" in a JS codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
