korbit-ai[bot] commented on code in PR #32506:
URL: https://github.com/apache/superset/pull/32506#discussion_r1980519070
##########
superset/db_engine_specs/postgres.py:
##########
@@ -411,7 +411,9 @@ def get_table_names(
)
@staticmethod
- def get_extra_params(database: Database) -> dict[str, Any]:
+ def get_extra_params(
+ database: Database, source: QuerySource | None = None
+ ) -> dict[str, Any]:
Review Comment:
@villebro, I see your point that too many unnecessary comments can be
distracting. Perhaps a reasonable compromise would be to augment the overall
documentation of the 'BaseEngineSpec' class to clarify the nature of its
methods' parameters? Also, I agree on focusing our comments on crucial
information that is not immediately apparent from the codebase itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
