villebro commented on code in PR #32506:
URL: https://github.com/apache/superset/pull/32506#discussion_r1980416946
##########
superset/db_engine_specs/base.py:
##########
@@ -1023,7 +1023,6 @@ def alter_new_orm_column(cls, orm_col: TableColumn) ->
None:
For instance special column like `__time` for Druid can be
set to is_dttm=True. Note that this only gets called when new
columns are detected/created"""
- # TODO: Fix circular import caused by importing TableColumn
Review Comment:
Bycatch: these are redundant (we have `TYPE_CHECKING` for this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
