korbit-ai[bot] commented on code in PR #32506:
URL: https://github.com/apache/superset/pull/32506#discussion_r1980506331
##########
superset/db_engine_specs/postgres.py:
##########
@@ -411,7 +411,9 @@ def get_table_names(
)
@staticmethod
- def get_extra_params(database: Database) -> dict[str, Any]:
+ def get_extra_params(
+ database: Database, source: QuerySource | None = None
+ ) -> dict[str, Any]:
Review Comment:
Thank you for your explanation, I understand now that because
`BaseEngineSpec` provides the foundation for other database implementations,
it's not unexpected to have redundant parameters across methods. It might be
helpful in the future to include this point in the comments or the method's
docstring to clarify this for any new developers on the project. This will help
them understand why `source` is included in the parameters but not used in the
function body. Appreciate the work you've done here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
