villebro commented on code in PR #32506:
URL: https://github.com/apache/superset/pull/32506#discussion_r1982173579
##########
tests/unit_tests/db_engine_specs/test_trino.py:
##########
@@ -81,7 +84,7 @@ def _assert_columns_equal(actual_cols, expected_cols) -> None:
@pytest.mark.parametrize(
"extra,expected",
[
- ({}, {"engine_params": {"connect_args": {"source": USER_AGENT}}}),
+ ({}, {"engine_params": {"connect_args": {"source": "Apache
Superset"}}}),
Review Comment:
bycatch: I think it's usually better to assert literal expected values (e.g.
in case the original constant becomes corrupted by mistake)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
