sunnysabor commented on PR #7414: URL: https://github.com/apache/shenyu/pull/7414#issuecomment-5945398779
The requested change is on the current head `6c2060ca6cb735feced84af1f2fa861e238aa35a`: `syncDB()` now isolates persistence failures per instance, the scheduled task calls it directly, and `close()` uses that same resilient path so cache/executor cleanup still runs. The regression coverage verifies a failed instance is retried on the next sync and shutdown cleanup proceeds after persistence failure. The focused admin reactor passed 13 `InstanceCheckServiceTest` tests with Checkstyle clean. Hosted `pr_build` remains blocked before reaching admin by the unchanged `shenyu-client-core` `HeartbeatFailureIsolationTest` failure at line 57; it reproduces locally and is tracked separately in #7401. Hosted E2E, Kubernetes ingress/Gateway API, and other applicable checks passed; the integration workflow's HTTPS case failed before tests while pulling a missing image. Could you please re-review this updated head when convenient? Thanks for the guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
