sunnysabor commented on PR #7414: URL: https://github.com/apache/shenyu/pull/7414#issuecomment-5945045333
Addressed the review in commit `6c2060ca6`. - Moved per-instance exception handling into `syncDB()` and scheduled that method directly; `close()` now uses the same resilient path, and the duplicate `syncDBSafely()` method is removed. - Expanded the regression test to cover two instances: one transient database failure does not stop the other instance, and the failed instance is retried on the next sync. Added coverage that shutdown still clears cached state after a persistence failure. Validation passed: `./mvnw -B -ntp -pl shenyu-admin -am -Dtest=InstanceCheckServiceTest -Dsurefire.failIfNoSpecifiedTests=false -Djacoco.skip=true -Dmaven.javadoc.skip=true -Drat.skip=true test` (13 tests, 0 failures/errors/skips; Checkstyle passed), plus `git diff --check`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
