mbien commented on code in PR #9307:
URL: https://github.com/apache/netbeans/pull/9307#discussion_r3044346193
##########
platform/core.startup/src/org/netbeans/core/startup/ModuleList.java:
##########
@@ -661,14 +680,23 @@ public void cacheReady() {
@Override
public void flushCaches(DataOutputStream os) throws IOException {
- ObjectOutputStream oss = new ObjectOutputStream(os);
for (Module m : mgr.getModules()) {
if (m.isFixed()) {
continue;
}
- Map<String, Object> prop = computeProperties(m);
- writeStatus(prop, oss);
- oss.writeObject(m.getDependencies());
+ // props
+ String list = computeProperties(m).entrySet()
+ .stream()
+ .map(e -> e.getKey() + "=" + e.getValue())
+ .collect(Collectors.joining(","));
Review Comment:
I dropped the idea of bitset encoding, since we would need a 3-state due to
the unset state.
instead I made a slight modification of the implementation:
- map entries are written as individual Strings
- key/value separator is still the `=`, but this is fine since the String
is split exactly once (`split(.., 1)`) and we know keys don't have that char in
them
changes are in separate commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
