matthiasblaesing commented on code in PR #9307:
URL: https://github.com/apache/netbeans/pull/9307#discussion_r3032809776
##########
platform/core.startup/src/org/netbeans/core/startup/ModuleList.java:
##########
@@ -661,14 +680,23 @@ public void cacheReady() {
@Override
public void flushCaches(DataOutputStream os) throws IOException {
- ObjectOutputStream oss = new ObjectOutputStream(os);
for (Module m : mgr.getModules()) {
if (m.isFixed()) {
continue;
}
- Map<String, Object> prop = computeProperties(m);
- writeStatus(prop, oss);
- oss.writeObject(m.getDependencies());
+ // props
+ String list = computeProperties(m).entrySet()
+ .stream()
+ .map(e -> e.getKey() + "=" + e.getValue())
+ .collect(Collectors.joining(","));
Review Comment:
This will break one either a key or a value contains `=` or `,`.
##########
platform/openide.modules/src/org/openide/modules/Dependency.java:
##########
@@ -361,6 +365,39 @@ public static Set<Dependency> create(int type, String
body) throws IllegalArgume
return deps;
}
+ /**
Review Comment:
This is an exported class - before this change an instance of `Dependency`
could only be created through `Dependency#create` now there is a option to
inject a `DataInput`. Is there an option to keep this an implementation detail?
The created format does not look like something I'd like people to
potentially rely on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
