mbien commented on code in PR #9307:
URL: https://github.com/apache/netbeans/pull/9307#discussion_r3034577020


##########
platform/openide.modules/src/org/openide/modules/Dependency.java:
##########
@@ -361,6 +365,39 @@ public static Set<Dependency> create(int type, String 
body) throws IllegalArgume
         return deps;
     }
 
+    /**

Review Comment:
   package private methods in `Dependency` + pasting this into the two modules 
is probably worse than a comment on the methods?
   ```java
   package org.openide.modules;
   //...
   public class DepAccessor {
       public static Dependency read(DataInput is) throws IOException {
           return Dependency.read(is);
       }
       public static void write(Dependency dep, DataOutput os) throws 
IOException {
           dep.write(os);
       }
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to