neilcsmith-net commented on code in PR #9307:
URL: https://github.com/apache/netbeans/pull/9307#discussion_r3044855749
##########
platform/openide.modules/src/org/openide/modules/Dependency.java:
##########
@@ -361,6 +365,39 @@ public static Set<Dependency> create(int type, String
body) throws IllegalArgume
return deps;
}
+ /**
Review Comment:
Sure, but this makes that custom IO code an explicit and public detail.
That was just a thought to fail fast in case someone did rely on it for
something else. I agree that's unlikely. Other options might be
`@PatchedPublic`(???) or just a second `create` method and put the
serialization in `Bootstrap` where it can be accessed by `Startup`?
I'm not against merging as is, just share some of the same reservations.
Doc is probably OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
