mbien commented on code in PR #9307:
URL: https://github.com/apache/netbeans/pull/9307#discussion_r3045005950
##########
platform/openide.modules/src/org/openide/modules/Dependency.java:
##########
@@ -361,6 +365,39 @@ public static Set<Dependency> create(int type, String
body) throws IllegalArgume
return deps;
}
+ /**
Review Comment:
ok. i thought your concern was something else, I didn't think about that
anymore since the doc already had a comment that the format was ephemeral.
Adding a second public factory method while trying to move the serialization
methods somewhere else where it is not public is also an option. This in fact
was the very first version of this, which simply made the constructor public. I
wasn't sure what was the lesser evil. But it looks like we want another public
factory method now (constructor equivalent).
> put the serialization in Bootstrap where it can be accessed by Startup?
right. will try something like that. As long the io code is not copied
around its ok with me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
