jjohannes commented on code in PR #279:
URL:
https://github.com/apache/logging-log4j-samples/pull/279#discussion_r2037188795
##########
.github/workflows/gradle-reusable-test.yaml:
##########
@@ -64,6 +64,17 @@ jobs:
develocity-url: https://develocity.apache.org
develocity-plugin-version: 3.18.2
+ - name: Test log4j-samples-gradle-metadata
+ id: build
+ shell: bash
+ env:
+ LOG4J_VERSION: ${{ inputs.log4j-version }}
+ LOG4J_REPOSITORY_URL: ${{ inputs.log4j-repository-url }}
+ run: |
+ ./gradlew \
+ -Plog4j.version=$LOG4J_VERSION \
+ -Plog4j.repository.url=$LOG4J_REPOSITORY_URL \
Review Comment:
The property is used in `settings.gradle` as I now kept it as it was:
https://github.com/apache/logging-log4j-samples/blob/bf205b7c0bf54897c98fab19a3e9847266cb560b/settings.gradle#L39
I would keep it like this. Then it is consistent how the properties are
passed in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
