jjohannes commented on code in PR #279: URL: https://github.com/apache/logging-log4j-samples/pull/279#discussion_r2005638916
########## log4j-samples-gradle-metadata/gradlew: ########## @@ -0,0 +1,251 @@ +#!/bin/sh Review Comment: I did the following: - Moved the wrapper from the Android example to the root (and not add a second one) - Add a `settings.gradle` to the root as a "umbrella build" that includes all Gradle samples (android and the new one) into a composed build. When you open the root in IDEA, it will now ask you if you want to open it as Maven project (for the Maven samples) or Gradle project (for the Gradle samples). From the command line, you can also run samples from the root or go into the individual sample projects. This feels like a good solution to me. Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
