ppkarwasz commented on code in PR #279: URL: https://github.com/apache/logging-log4j-samples/pull/279#discussion_r2037015235
########## .github/workflows/gradle-reusable-test.yaml: ########## @@ -64,6 +64,17 @@ jobs: develocity-url: https://develocity.apache.org develocity-plugin-version: 3.18.2 + - name: Test log4j-samples-gradle-metadata + id: build + shell: bash + env: + LOG4J_VERSION: ${{ inputs.log4j-version }} + LOG4J_REPOSITORY_URL: ${{ inputs.log4j-repository-url }} + run: | + ./gradlew \ + -Plog4j.version=$LOG4J_VERSION \ + -Plog4j.repository.url=$LOG4J_REPOSITORY_URL \ Review Comment: I guess this line is no longer needed, since `settings.gradle` accesses the `LOG4J_REPOSITORY_URL` environment variable directly. Am I right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org