jjohannes commented on code in PR #279: URL: https://github.com/apache/logging-log4j-samples/pull/279#discussion_r1978265989
########## log4j-samples-gradle-metadata/gradlew: ########## @@ -0,0 +1,251 @@ +#!/bin/sh Review Comment: To answer this and https://github.com/apache/logging-log4j-samples/pull/279#discussion_r1976651888 (Jar in repo) together: Both examples are independent projects. There is not really a good way to share a wrapper between two independent projects. What I would propose is to remove it completely (scrips and Jars) from both examples – Android and this one – and configure the Gradle version in the [`gradle/actions/setup-gradle` action instead](https://github.com/gradle/actions/blob/main/docs/setup-gradle.md#build-with-a-specific-gradle-version). Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
